fix(context): reject app shells for binary downloads#86
Merged
Conversation
3f307f9 to
5fb1850
Compare
Member
Author
|
Focused validation on the current branch:
QA packet to run before merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pytest tests/test_context_commands.py -qValueErrorinstead of writing an HTML page asimage.pngContext
When a gateway or upload URL resolves to an app shell or error page,
axctl context downloadshould fail loudly instead of silently saving garbage bytes. This is a guardrail in the CLI; it does not replace the backend/platform fix for missing upload blobs.