[REFACTOR]: use NGNMarket ETF endpoint for ETF ticker resolution and validation#50
Merged
Conversation
Pass the asset_class parameter when fetching metadata from ngnmarket to improve matching accuracy for assets in that market.
FakeNgnMarketAdapter.get_asset_metadata Update mock and tests to pass the new asset_class parameter, ensuring the CSV import interaction correctly forwards asset class information to the NGN market adapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_etf_detail()toNgnMarketAdapterwhich callsGET /etfs/{symbol}— the correct endpoint for ETF assets on NGNMarket (previously the index endpoint was always used as a fallback, even for ETFs)get_asset_metadata()now accepts an optionalasset_classparam; when"etf", it hits the ETF endpoint first and falls back to the index endpoint if the ETF endpoint returns nothingasset_classthroughCsvImportInteractor._get_asset_metadata()so CSV imports route to the right endpoint based on the row's asset class columnGET /assets/validateendpoint now accepts an optionalasset_classquery param and forwards it to NGNMarket, so ticker validation also uses the correct endpointvalidateTicker()passes the trade form'sasset_classfield when calling the validate endpointTest plan
/etfs/{symbol}supported: truepytest tests/unit/adapters/outbound/market_data/test_ngnmarket_adapter.py tests/mocking/application/csv_import/)