fix(web): remove UI controls that imply unimplemented features#49
Merged
aykhan019 merged 1 commit intoMay 31, 2026
Merged
Conversation
Several screens rendered decorative filter controls that were never wired to the API, and one hero metric was mislabeled: - Top artists: the 7d/30d/90d/1y period pills were non-interactive and the underlying query is all-time. Replace them with a single "All time" label. - History: the "source" filter pills did nothing (fetchHistory only takes a page number). Remove them. - Overview: the "Minutes listened · 30d" tile is the sum of the top 3 artists and is all-time, not 30d. Relabel it "top artists" and reword the hero copy to "across your top artists". - Overview: drop the unsupported "180M tracks indexed" capability sub-label; the catalog holds ~170K tracks.
|
@fateh-mammadli is attempting to deploy a commit to the Aykhan's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A few analytics screens rendered filter controls and labels that suggest features the API doesn't provide. They draw the eye (and questions) without doing anything.
What changed
7d / 30d / 90d / 1yperiod pills were non-interactive<span>s and the query is all-time. Replaced with a single honest "All time" label.All sources / From a preview / …pills did nothing (fetchHistoryonly takes a page number). Removed them (and the now-unusedP2Pillimport).No behavior change beyond removing misleading affordances; if real filtering is wanted later it can be wired end-to-end.
Verification
pnpm --filter @statify/web typecheck,eslint, andpnpm --filter @statify/web test(61 tests) all pass.