fix(libcamera): drop MergePolicy arg for Debian Trixie libcamera ABI#211
Open
issic wants to merge 1 commit into
Open
fix(libcamera): drop MergePolicy arg for Debian Trixie libcamera ABI#211issic wants to merge 1 commit into
issic wants to merge 1 commit into
Conversation
Contributor
Contributor
|
It's still compiling and I don't see any issue immediately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Debian 13 (Trixie), the system-packaged libcamera does not expose the
two-argument
ControlList::merge(other, MergePolicy)overload, sodevice/libcamera/buffer.ccfails to compile.This patch drops the explicit
MergePolicy::OverwriteExistingargument,falling back to the single-argument form which is present in both the
Trixie-packaged libcamera and in the rpt-suffixed Raspberry Pi builds.
OverwriteExistingis the default merge behavior in the single-argumentoverload, so semantics are preserved on platforms where the two-argument
form is available.
Tested on
Notes
is unchanged.