Skip to content

fix(libcamera): drop MergePolicy arg for Debian Trixie libcamera ABI#211

Open
issic wants to merge 1 commit into
ayufan:mainfrom
issic:trixie-libcamera-compat
Open

fix(libcamera): drop MergePolicy arg for Debian Trixie libcamera ABI#211
issic wants to merge 1 commit into
ayufan:mainfrom
issic:trixie-libcamera-compat

Conversation

@issic
Copy link
Copy Markdown

@issic issic commented May 15, 2026

Summary

On Debian 13 (Trixie), the system-packaged libcamera does not expose the
two-argument ControlList::merge(other, MergePolicy) overload, so
device/libcamera/buffer.cc fails to compile.

This patch drops the explicit MergePolicy::OverwriteExisting argument,
falling back to the single-argument form which is present in both the
Trixie-packaged libcamera and in the rpt-suffixed Raspberry Pi builds.
OverwriteExisting is the default merge behavior in the single-argument
overload, so semantics are preserved on platforms where the two-argument
form is available.

Tested on

  • Debian 13 (Trixie), aarch64, BTT CB1 on Manta M4P
  • Camera: Raspberry Pi Camera Module via libcamera
  • Build: clean, runtime: streams at 1280x720 / 15fps with no regression

Notes

@mryel00
Copy link
Copy Markdown
Contributor

mryel00 commented May 15, 2026

Iirc there was an issue if MergePolicy::OverwriteExisting wasn't set.
I explicitely added this commit back when I fixed #206: a9f4939
edit: I have to check it myself, as I don't know it out of my head

@mryel00
Copy link
Copy Markdown
Contributor

mryel00 commented May 15, 2026

It's still compiling and I don't see any issue immediately.
I might have set it to copy the old behavior of moving the controls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants