fix(embedder): use correct sentence-transformers method name#2
Open
l984-451 wants to merge 1 commit into
Open
Conversation
`SentenceTransformer` has `get_sentence_embedding_dimension()`, not `get_embedding_dimension()`. The wrong name raised AttributeError on embedder init, silently disabling semantic search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On fresh startup, the embedder fails to initialize with:
This silently disables semantic search across the timeline (FTS5 keyword search still works, but
embedding-backed search viaengine/embedder.py:embed_activitynever runs).Fix
engine/embedder.py:31callsself._model.get_embedding_dimension()butsentence_transformers.SentenceTransformer(versions 3.x, including the pinned3.3.1) exposes the method asget_sentence_embedding_dimension(). One-character… well, fifteen-character fix.Verified locally with
sentence-transformers==3.3.1:After the fix, embedder boots cleanly and
status.analysis.embedder_availableistrue.