Apply TeX Gyre fonts by overriding Minima theme styles correctly#7
Open
azayrahmad wants to merge 3 commits into
Open
Apply TeX Gyre fonts by overriding Minima theme styles correctly#7azayrahmad wants to merge 3 commits into
azayrahmad wants to merge 3 commits into
Conversation
…ma theme's main stylesheet and head inclusion logic. - Renamed `assets/css/main.scss` to `assets/main.scss` to correctly override the theme's default stylesheet. - Updated `assets/main.scss` to properly import the Minima theme and use custom font variables. - Corrected font asset paths to be relative to the new stylesheet location. - Restructured `_includes` to follow standard Jekyll practices for custom head content by overriding `_includes/head.html` and including `_includes/head_custom.html`. - Verified changes visually using Playwright and confirmed font application in generated site output. Co-authored-by: azayrahmad <10110227+azayrahmad@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ma theme's stylesheet and head inclusion. - Renamed `assets/css/main.scss` to `assets/main.scss` to correctly override the Minima theme's default stylesheet and ensure it is compiled to `/assets/main.css`. - Updated `assets/main.scss` to use Liquid's `relative_url` filter for font asset paths, ensuring correct resolution on GitHub Pages. - Removed `!default` from the `$base-font-family` override and added a `body` font-family override to guarantee the TeX Gyre fonts take precedence. - Integrated the Minima theme styles using `@import "minima";`. - Created an override for `_includes/head.html` to link to `/assets/main.css` and include a custom head hook. - Added `_includes/head_custom.html` to manage custom head elements like Google site verification. - Verified font loading and application via Playwright computed styles and visual screenshots. Co-authored-by: azayrahmad <10110227+azayrahmad@users.noreply.github.com>
…ma theme's stylesheet and head inclusion logic. - Renamed `assets/css/main.scss` to `assets/main.scss` to correctly override the Minima theme's default stylesheet and ensure it is compiled to `/assets/main.css`. - Updated `assets/main.scss` with absolute font URLs and reinforced font family overrides for headings and navigation using higher specificity selectors. - Overrode `_includes/head.html` to provide a hook for custom head elements (`_includes/head_custom.html`), bypassing version-specific theme limitations. - Verified font application (Heros and Termes) using Playwright, confirming successful 200 status for font asset requests and correct computed styles on multiple pages. - Addresses the disconnect between custom SCSS and the Jekyll build process in the Minima theme context. Co-authored-by: azayrahmad <10110227+azayrahmad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TeX Gyre fonts were not being applied because the project's custom styles were defined in
assets/css/main.scss, which resulted in a standaloneassets/css/main.cssthat was not being linked by the Minima theme's defaulthead.html.To fix this, I have:
assets/main.scssso that it overrides the Minima theme's default stylesheet and gets compiled into the expectedassets/main.css.@import "minima";to the newassets/main.scss, while overriding the$base-font-familyvariable.assets/fonts/directory._includes/head.htmlto include a new_includes/head_custom.html, which contains the Google site verification tag and ensures that future custom head elements can be easily added._site/assets/main.csscontains both the theme's base styles and the custom font definitions, and that the HTML files correctly link to this stylesheet.PR created automatically by Jules for task 1719814121853632813 started by @azayrahmad