fix: Selectively show custom checkbox component#124
Merged
azeezat merged 1 commit intoazeezat:mainfrom Aug 24, 2025
Merged
Conversation
Fixes azeezat#123 Signed-off-by: Andreas Maerten <24669514+Yimura@users.noreply.github.com>
Contributor
Author
|
@azeezat, let me know if the new code requires further documentation or commenting. |
Yimura
added a commit
to Yimura/RemoteUnlockApp
that referenced
this pull request
Aug 22, 2025
Owner
|
Thanks @Yimura for this fix! |
Owner
|
🚀 This pull request is included in v2.1.8. See Release 2.1.8 for release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the behaviour of the underlying checkbox component to not render unless the item is selected.
Fixes #123
Type of change
People previously having relied on their custom checkbox always rendering will be impacted. As the checkbox is unable to know if it's selected or not I wouldn't expect anyone to be negatively impacted by this.
How Has This Been Tested?
Before
After
Test Configuration:
Checklist: