Skip to content

Chore: Update SmartAI and Conditions defines and comments. #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheSCREWEDSoftware wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Chore: Update SmartAI and Conditions defines and comments. #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd7e50f
Added missing SAI from aowow
TheSCREWEDSoftware May 25, 2026
a362367
Added missing and updated Conditions
TheSCREWEDSoftware May 25, 2026
c16b83c
Updated Conditions and SAI commnets for un-used or different names
TheSCREWEDSoftware May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions includes/components/Conditions/Conditions.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ class Conditions
// public const SRC_SPELL_TERRAIN_SWAP = 25; // - ❌ reserved for TC master
// public const SRC_SPELL_PHASE = 26; // - ❌ reserved for TC master
// public const SRC_SPELL_GRAVEYARD = 27; // - ❌ reserved for TC master
// public const SRC_SPELL_AREATRIGGER = 28; // - ❌ reserved for TC master
// public const SRC_SPELL_CONVERSATION_LINE = 29; // - ❌ reserved for TC master
public const SRC_PLAYER_LOOT_TEMPLATE = 28; // tplEntry, itemId, null
public const SRC_CREATURE_RESPAWN = 29; // null, npcId, null
public const SRC_AREATRIGGER_CLIENT = 30; // null, atId, null
// public const SRC_SPELL_TRAINER_SPELL = 31; // - ❌ reserved for TC master
// public const SRC_SPELL_OBJECT_VISIBILITY = 32; // - ❌ reserved for TC master
Expand Down Expand Up @@ -109,14 +109,21 @@ class Conditions
public const QUESTSTATE = 47; // questId, stateMask, NULL
public const QUEST_OBJECTIVE_PROGRESS = 48; // questId, objectiveIdx, count
public const DIFFICULTY_ID = 49; // map has difficulty id: difficulty, NULL, NULL
public const GAMEMASTER = 50; // player is GM: canBeGM?, NULL, NULL
public const GAMEMASTER = 50; // player is GM: canBeGM?, NULL, NULL - Un-used TrinityCore, doesn't exist or works different in AzerothCore
// public const OBJECT_ENTRY_GUID_MASTER = 51; // ❌ reserved for TC master
// public const TYPE_MASK_MASTER = 52; // ❌ reserved for TC master
// public const BATTLE_PET_COUNT = 53; // ❌ reserved for TC master
// public const SCENARIO_STEP = 54; // ❌ reserved for TC master
// public const SCENE_IN_PROGRESS = 55; // ❌ reserved for TC master
// public const PLAYER_CONDITION = 56; // ❌ reserved for TC master

public const QUEST_SATISFY_EXCLUSIVE = 101; // quest_id satisfied exclusive group: questId, NULL, NULL
public const HAS_AURA_TYPE = 102; // has aura type: auraType, NULL, NULL
public const WORLD_SCRIPT = 103; // WorldState::IsConditionFulfilled: conditionId, state, NULL
public const AI_DATA = 104; // AI::GetData returns value: dataId, value, NULL
public const PLAYER_QUEUED_RANDOM_DUNGEON = 105; // queued for RDF: checkDiff?, difficulty, NULL
public const UNIT_IN_COMBAT = 106; // unit is engaged in combat: NULL, NULL, NULL

private const IDX_SRC_GROUP = 0;
private const IDX_SRC_ENTRY = 1;
private const IDX_SRC_ID = 2;
Expand Down Expand Up @@ -148,6 +155,8 @@ class Conditions
self::SRC_SMART_EVENT => [true, true, true, null],
self::SRC_NPC_VENDOR => [Type::NPC, Type::ITEM, null, null],
self::SRC_SPELL_PROC => [null, Type::SPELL, null, null],
self::SRC_PLAYER_LOOT_TEMPLATE => [null, Type::ITEM, null, null],
self::SRC_CREATURE_RESPAWN => [null, Type::NPC, null, null],
self::SRC_AREATRIGGER_CLIENT => [null, Type::AREATRIGGER, null, null]
);

Expand Down Expand Up @@ -206,7 +215,14 @@ class Conditions
self::QUESTSTATE => [Type::QUEST, true, null, null],
self::QUEST_OBJECTIVE_PROGRESS => [Type::QUEST, true, true, null],
self::DIFFICULTY_ID => [true, null, null, null],
self::GAMEMASTER => [true, null, null, null]
self::GAMEMASTER => [true, null, null, null],

self::QUEST_SATISFY_EXCLUSIVE => [Type::QUEST, null, null, null],
self::HAS_AURA_TYPE => [true, null, null, null],
self::WORLD_SCRIPT => [true, true, null, null],
self::AI_DATA => [true, true, null, null],
self::PLAYER_QUEUED_RANDOM_DUNGEON => [true, true, null, null],
self::UNIT_IN_COMBAT => [null, null, null, null]
);

private $jsGlobals = [];
Expand Down
Loading