fix: override-aware viability minimums and odd-wave trim under strict EvenTeams#11
Conversation
IsViable and the tier-c smallest-min fallback read the raw template MinPlayersPerTeam, ignoring Battleground.Override.LowLevels.MinPlayers. Resolve the bucket's bracket on the candidate BG's own map and use the same minimum core matching uses, falling back to the raw template value when no bracket resolves.
With CFBG.EvenTeams.Enabled=1 and MaxPlayersThreshold=0 the CFBG queue never invites an odd total, so one player of every odd wave was left in queue forever. Re-validate the bucket first, and when the wave plus the uninvited waiters comes out odd, leave the newest player unqueued for this pass; the next pass picks them up. The trim self-disables when CFBG or EvenTeams is off, the threshold is above 0, or the module runs faction-vs-faction.
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FrancescoBorzi
changed the title
1 participant
No description provided.