fix: operator warnings and docs for CrossFaction and the first-pass warning window#12
Conversation
CountUninvitedWaiters split waiter counts by gInfo->teamId, which CFBG staging overwrites on every staging attempt and does not restore on failure, so with CrossFaction = 0 per-faction viability drifted across passes. Split by RealTeamID instead, which the core writes exactly once at queue join and never mutates. Also warn once per config load when CrossFaction = 1 runs without an active cross-faction matcher (uninvited players sitting in a faction-specific NORMAL bucket can never pop on a stock core), and document the matcher coupling in conf.dist and the README.
LoadConfig warned when WarningLeadTime swallowed the Interval half of the warning window but not the InitialDelay half: with 0 < InitialDelay <= WarningLeadTime the first pass silently queues everyone without the advertised broadcast. Log-only; default configs (InitialDelay = 0) stay silent.
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
No description provided.