Use module WG tracking and add battlefield hooks#135
Merged
Conversation
Replace reliance on core GetPlayersInWarCount() with a module-owned _wgWarPlayers set for WorldGuard (WG) balancing, and add battlefield hooks to manage fake-team assignment lifecycle. Changes: add BATTLEFIELDHOOK_ON_PLAYER_ENTER_ZONE and BATTLEFIELDHOOK_ON_PLAYER_LEAVE_WAR; implement OnBattlefieldPlayerEnterZone to assign an alternate team only during active war (and skip already-faked players); implement OnBattlefieldPlayerJoinWar to handle fallback assignments and to insert players into _wgWarPlayers when they accept invites; implement OnBattlefieldPlayerLeaveWar to remove players from _wgWarPlayers; update OnBattlefieldPlayerLeaveZone to clear fake players and perform a safe GUID erase as a catch-all. These changes ensure balance decisions are based on clean, module-maintained state and avoid leaving stale entries in core battlefield structures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace reliance on core GetPlayersInWarCount() with a module-owned _wgWarPlayers set for WorldGuard (WG) balancing, and add battlefield hooks to manage fake-team assignment lifecycle. Changes: add BATTLEFIELDHOOK_ON_PLAYER_ENTER_ZONE and BATTLEFIELDHOOK_ON_PLAYER_LEAVE_WAR; implement OnBattlefieldPlayerEnterZone to assign an alternate team only during active war (and skip already-faked players); implement OnBattlefieldPlayerJoinWar to handle fallback assignments and to insert players into _wgWarPlayers when they accept invites; implement OnBattlefieldPlayerLeaveWar to remove players from _wgWarPlayers; update OnBattlefieldPlayerLeaveZone to clear fake players and perform a safe GUID erase as a catch-all. These changes ensure balance decisions are based on clean, module-maintained state and avoid leaving stale entries in core battlefield structures.