feat(WG): Split BF team assignment from visual transformation #136
Merged
Conversation
Introduce PrepareFakeTeamForBF and ApplyFakeVisualsForBF to replace the single SetFakeRaceAndMorphForBF call in the BF hooks. Team assignment (faction/team change) now happens before the invite bucket is written; the race/morph visuals are only applied once the player actually accepts the war invitation. Players who refuse or are kicked before accepting no longer receive a stale faction appearance. Also adds the OnBattlefieldBeforeInvitePlayerToWar hook subscription and the corresponding ScriptMgr call in Battlefield::InvitePlayerToWar so pre-war zone players are assigned to the correct team before m_InvitedPlayers is written. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.