Improve auto collection reliability and add vendor-sell fallback#226
Open
Aldori15 wants to merge 1 commit into
Open
Improve auto collection reliability and add vendor-sell fallback#226Aldori15 wants to merge 1 commit into
Aldori15 wants to merge 1 commit into
Conversation
Refactor appearance collection flow to rely on AddToDatabase item gating. - Centralize binding/trade/refund checks in AddToDatabase(). - Keep BOE/BIND_WHEN_USE items from being learned on bag acquire. - Allow NO_BIND items to be learned on acquire. - Update loot/create/store hooks to call AddToDatabase consistently. - Add vendor-sell safety net via OnPlayerCanSellItem (fromVendorSell=true).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves appearance auto collection reliability across normal gameplay.
Includes
Behavior
BIND_WHEN_EQUIPPED/BIND_WHEN_USE) are not learned immediately on pickup.NO_BINDitems are learned when they enter inventory.