docs: add text output section to C++ code standards#1178
Merged
Nyeriah merged 2 commits intoazerothcore:masterfrom Mar 19, 2026
Merged
docs: add text output section to C++ code standards#1178Nyeriah merged 2 commits intoazerothcore:masterfrom
Nyeriah merged 2 commits intoazerothcore:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation to the C++ code standards to guide how scripts should emit user-facing text and how new strings should be localized.
Changes:
- Introduces a “Text Output” section recommending
acore_stringfor script text output. - States a requirement to provide localization for new strings across available languages, with an AI translation tip.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Kitzunu
reviewed
Mar 15, 2026
|
|
||
| NPC dialog, emotes, and other in-game text that is managed via database text systems (such as `creature_text`, `broadcast_text`, etc.) should continue to use those systems instead of `acore_string`. | ||
|
|
||
| When adding new strings, localization must be provided for all available languages. |
Kitzunu
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new section to the
docs/cpp-code-standards.mdfile, introducing guidelines for text output and localization in scripts. The update emphasizes the use ofacore_stringfor script text output and requires localization for all new strings.Text output and localization guidelines:
acore_stringfor all script text output, such as command handlers and script messages.