[ISSUE-3] Audio support#23
Open
azihassan wants to merge 18 commits into
Open
Conversation
azihassan
force-pushed
the
fix/ISSUE-3-audio
branch
from
March 30, 2025 13:23
a4bce89 to
176b0a6
Compare
azihassan
force-pushed
the
fix/ISSUE-3-audio
branch
from
March 30, 2025 15:16
176b0a6 to
cb45edf
Compare
azihassan
force-pushed
the
fix/ISSUE-3-audio
branch
2 times, most recently
from
April 2, 2025 04:37
a4d8530 to
ca763df
Compare
azihassan
force-pushed
the
fix/ISSUE-3-audio
branch
from
April 2, 2025 04:50
ca763df to
b599bd0
Compare
azihassan
force-pushed
the
fix/ISSUE-3-audio
branch
from
April 8, 2025 23:19
d7b56e0 to
9d90c90
Compare
azihassan
force-pushed
the
fix/ISSUE-3-audio
branch
from
April 15, 2025 00:29
4c0ee87 to
7f1715f
Compare
azihassan
force-pushed
the
fix/ISSUE-3-audio
branch
from
April 15, 2025 00:37
7f1715f to
9cd9f1e
Compare
- Add logging - Disable SDL_INIT_AUDIO flag - Disable audio in intro video - Disable sound duplication - Disable IsPlaying check in effects_play_sound, otherwise sfx only play once because snd_is_playing returns true for the sfx channel - Disable IsPlaying check in PlayEffect (monster.cpp) for the same reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue: #3