Open
Conversation
- Add SanitizeConnectionString utility to redact passwords from URLs - Update beef/redis.go to sanitize Redis connection strings in logs - Update queue/redis.go to sanitize Redis connection strings in logs - Update dependencies with go mod tidy Security: Prevents credentials from being leaked in application logs
- Replace log.Println with slog.Debug for structured logging - Connection strings only logged at DEBUG level - Prevents logs in production unless debug level is enabled - Maintains sanitization of credentials when debug is enabled
- Add utils.SanitizeConnectionString() to redact passwords - Update beef/redis.go and queue/redis.go to use slog.Debug() - Rename cleanConnString to connStringForRedis for clarity - Remove unused log import from queue/redis.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Redis connection strings with credentials were being logged in plaintext at all times, exposing sensitive information in application logs.
Example of insecure log output:
Solution
internal/utils/sanitize.gowithSanitizeConnectionString()utilitybeef/redis.goto useslog.Debugwith sanitized connection stringsqueue/redis.goto useslog.Debugwith sanitized connection stringsResult
Security Impact
slog) with proper log levels