Open
Conversation
This makes the code a bit more performant by removing the wrapping RelMemberType as a separate enum. No point now with protobuf3 as it gets generated as is. I had to modify the .proto file to make the casing consistent, but eventually I do hope the protobuf lib itself can do that on the fly.
Owner
|
Hey nyurik, sorry for taking so long to respond. I would refrain from changing the *.proto files in a semantic way for now, as it would make it harder to track the upstream changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the code a bit more performant by removing the wrapping RelMemberType as a separate enum. No point now with protobuf3 as it gets generated as is.
I had to modify the .proto file to make the casing consistent, but eventually I do hope the protobuf lib itself can do that on the fly.
See also stepancheg/rust-protobuf#639