Open
Conversation
Owner
|
Thanks for this PR! |
Author
|
@b-r-u I've updated with the requested test and fixed the issues from the first test run. Could you rerun and give me another review? Thanks! |
Author
|
@b-r-u wanted to follow-up, when you get some time could you kick off the tests again and review? |
|
Hello! |
5ff9603 to
2a1372f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #47, adds support for async streaming of OSM PBFs. Using
object_storeas the input interface for flexibility - it supports most cloud providers, HTTP, and local files.Example usage in docs and here: https://github.com/brad-richardson/osm-pbf-parquet/pull/15/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R116