Skip to content

Async blob reader#48

Open
brad-richardson wants to merge 1 commit intob-r-u:mainfrom
brad-richardson:async-blob-reader
Open

Async blob reader#48
brad-richardson wants to merge 1 commit intob-r-u:mainfrom
brad-richardson:async-blob-reader

Conversation

@brad-richardson
Copy link
Copy Markdown

@brad-richardson brad-richardson commented Sep 3, 2024

As described in #47, adds support for async streaming of OSM PBFs. Using object_store as the input interface for flexibility - it supports most cloud providers, HTTP, and local files.

Example usage in docs and here: https://github.com/brad-richardson/osm-pbf-parquet/pull/15/files#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759R116

@b-r-u
Copy link
Copy Markdown
Owner

b-r-u commented Sep 4, 2024

Thanks for this PR!
Could you add a simple test to https://github.com/b-r-u/osmpbf/blob/main/tests/read.rs ?
Just like read_blobs() but using the AsyncBlobReader.

@brad-richardson
Copy link
Copy Markdown
Author

@b-r-u I've updated with the requested test and fixed the issues from the first test run. Could you rerun and give me another review? Thanks!

@brad-richardson
Copy link
Copy Markdown
Author

@b-r-u wanted to follow-up, when you get some time could you kick off the tests again and review?

@slavik-pastushenko
Copy link
Copy Markdown

Hello!
Do you know when it will be released?

Copilot AI review requested due to automatic review settings February 9, 2026 19:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants