Skip to content

104 provide a better error on provider lookup failure #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rads merged 2 commits into from
Mar 21, 2026
+24 −6
Merged

104 provide a better error on provider lookup failure #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26f4722
104 provide a better error on provider lookup failure
fpischedda Mar 4, 2026
eae2055
Use `get-lib-provider` in `git-ssh-url`
rads Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions bbin
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,13 @@ WARNING: (We won't make any changes without asking you first.)
(->> (reduce #(str/replace %1 %2 "") lib (keys providers))
symbol))

(defn- get-lib-provider [lib]
(if-let [provider (some #(when (re-seq (key %) (str lib)) %) providers)]
provider
(throw (ex-info "Unable to find an appropriate provider" {:lib lib}))))

(defn git-http-url [lib]
(let [provider (some #(when (re-seq (key %) (str lib)) %) providers)
(let [provider (get-lib-provider lib)
s (clean-lib-str (str lib))]
(case (val provider)
:github (str "https://github.com/" s ".git")
Expand All @@ -171,7 +176,7 @@ WARNING: (We won't make any changes without asking you first.)
:sourcehut (str "https://git.sr.ht/~" s))))

(defn git-ssh-url [lib]
(let [provider (some #(when (re-seq (key %) (str lib)) %) providers)
(let [provider (get-lib-provider lib)
s (clean-lib-str (str lib))]
(case (val provider)
:github (str "git@github.com:" s ".git")
Expand All @@ -187,7 +192,7 @@ WARNING: (We won't make any changes without asking you first.)
(ensure-git-dir client url)
url)
(catch Exception e
(if (re-seq #"^Unable to clone " (ex-message e))
(if (re-seq #"^Unable to " (ex-message e))
(let [url (git-ssh-url lib)]
(ensure-git-dir client url)
url)
Expand Down
11 changes: 8 additions & 3 deletions src/babashka/bbin/git.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,13 @@
(->> (reduce #(str/replace %1 %2 "") lib (keys providers))
symbol))

(defn- get-lib-provider [lib]
(if-let [provider (some #(when (re-seq (key %) (str lib)) %) providers)]
provider
(throw (ex-info "Unable to find an appropriate provider" {:lib lib}))))

(defn git-http-url [lib]
(let [provider (some #(when (re-seq (key %) (str lib)) %) providers)
(let [provider (get-lib-provider lib)
s (clean-lib-str (str lib))]
(case (val provider)
:github (str "https://github.com/" s ".git")
Expand All @@ -64,7 +69,7 @@
:sourcehut (str "https://git.sr.ht/~" s))))

(defn git-ssh-url [lib]
(let [provider (some #(when (re-seq (key %) (str lib)) %) providers)
(let [provider (get-lib-provider lib)
s (clean-lib-str (str lib))]
(case (val provider)
:github (str "git@github.com:" s ".git")
Expand All @@ -80,7 +85,7 @@
(ensure-git-dir client url)
url)
(catch Exception e
(if (re-seq #"^Unable to clone " (ex-message e))
(if (re-seq #"^Unable to " (ex-message e))
(let [url (git-ssh-url lib)]
(ensure-git-dir client url)
url)
Expand Down
8 changes: 8 additions & 0 deletions test/babashka/bbin/scripts/git_dir_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,11 @@
(is (= git-ssh-url-lib out))
(is (fs/exists? bin-file))
(is (= "Hello world!" (tu/run-bin-script 'hello))))))

(deftest install-lib-fail-if-provider-not-found
(testing "install lib name fails provider lookup"
(tu/reset-test-dir)
(dirs/ensure-bbin-dirs {})
(let [cli-opts {:script/lib "something-broken"}]
(is (thrown? Exception "Unable to find an appropriate provider" (tu/run-install cli-opts)))
)))
Loading