Skip to content

Revert #1055 ("use module.findPackageJSON API")#1066

Merged
nicolo-ribaudo merged 1 commit intomainfrom
revert-1055
Mar 9, 2026
Merged

Revert #1055 ("use module.findPackageJSON API")#1066
nicolo-ribaudo merged 1 commit intomainfrom
revert-1055

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 9, 2026

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Docs update
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

This PR reverts #1055. Per Node.js docs, module.findPackageJSON does not support custom resolve hooks, which Yarn PnP may depends on.

Other information:

Fixes #1065.

@nicolo-ribaudo nicolo-ribaudo changed the title revert #1055 Revert #1055 ("use module.findPackageJSON API") Mar 9, 2026
@nicolo-ribaudo nicolo-ribaudo merged commit a0a2617 into main Mar 9, 2026
32 checks passed
@nicolo-ribaudo
Copy link
Member

Released!

mergify bot added a commit to robfrank/linklift that referenced this pull request Mar 19, 2026
…skip ci]

Bumps [babel-loader](https://github.com/babel/babel-loader) from 10.1.0 to 10.1.1.
Release notes

*Sourced from [babel-loader's releases](https://github.com/babel/babel-loader/releases).*

> v10.1.1
> -------
>
> What's Changed
> --------------
>
> * Revert [#1055](https://redirect.github.com/babel/babel-loader/issues/1055) ("use `module.findPackageJSON` API") by [`@​JLHwung`](https://github.com/JLHwung) in [babel/babel-loader#1066](https://redirect.github.com/babel/babel-loader/pull/1066)
>
> **Full Changelog**: <babel/babel-loader@v10.1.0...v10.1.1>


Commits

* [`da60210`](babel/babel-loader@da60210) 10.1.1
* [`a0a2617`](babel/babel-loader@a0a2617) Revert [#1055](https://redirect.github.com/babel/babel-loader/issues/1055) ("use `module.findPackageJSON` API") ([#1066](https://redirect.github.com/babel/babel-loader/issues/1066))
* See full diff in [compare view](babel/babel-loader@v10.1.0...v10.1.1)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=babel-loader&package-manager=npm\_and\_yarn&previous-version=10.1.0&new-version=10.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module build failing when upgrading to 10.1.0

2 participants