Skip to content

fix: decoding failed and add "x-" prefixed headers to response #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
babeuloula merged 1 commit into from
May 9, 2026
Merged

fix: decoding failed and add "x-" prefixed headers to response #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/Proxy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,25 +68,29 @@ public function response(string $file, ?Options $options = null, array $headers

$newResponse->setContent($response->getContent());

$copiedHeaders = [
$standardHeaders = [
'last-modified',
'expires',
'etag',
'cache-control',
'content-encoding',
'content-type',
'content-length',
'vary',
'x-content-type-options',
'x-dominant-color',
];

foreach ($copiedHeaders as $header) {
if (false === \array_key_exists($header, $response->getHeaders())) {
$responseHeaders = $response->getHeaders();

foreach ($standardHeaders as $header) {
if (false === \array_key_exists($header, $responseHeaders)) {
continue;
}

$newResponse->headers->set($header, $response->getHeaders()[$header]);
$newResponse->headers->set($header, $responseHeaders[$header]);
}

foreach ($responseHeaders as $header => $values) {
if (true === str_starts_with($header, 'x-')) {
$newResponse->headers->set($header, $values);
}
}

$newResponse->headers->set(AbstractSessionListener::NO_AUTO_CACHE_CONTROL_HEADER, 'true');
Expand Down
24 changes: 21 additions & 3 deletions tests/ProxyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ public function testResponseFetchesCdnAndCopiesWhitelistedHeaders(): void
'vary' => ['Accept'],
'x-content-type-options' => ['nosniff'],
'x-dominant-color' => ['#ff0000'],
'x-custom-header' => ['custom-value'],
],
]
)
Expand All @@ -89,6 +90,7 @@ public function testResponseFetchesCdnAndCopiesWhitelistedHeaders(): void
self::assertSame('"abc123"', $response->headers->get('etag'));
self::assertSame('nosniff', $response->headers->get('x-content-type-options'));
self::assertSame('#ff0000', $response->headers->get('x-dominant-color'));
self::assertSame('custom-value', $response->headers->get('x-custom-header'));
}

public function testResponseSetsNoCacheControlHeader(): void
Expand All @@ -99,20 +101,36 @@ public function testResponseSetsNoCacheControlHeader(): void
self::assertSame('true', $response->headers->get(AbstractSessionListener::NO_AUTO_CACHE_CONTROL_HEADER));
}

public function testResponseIgnoresNonWhitelistedHeaders(): void
public function testResponseIgnoresNonXNonWhitelistedHeaders(): void
{
$client = new MockHttpClient(
new MockResponse(
'content',
[
'response_headers' => ['x-secret' => ['value']],
'response_headers' => ['server' => ['Apache']],
]
)
);

$response = $this->makeProxy($client)->response('image.jpg');

self::assertFalse($response->headers->has('x-secret'));
self::assertFalse($response->headers->has('server'));
}

public function testResponseForwardsAllXPrefixedHeaders(): void
{
$client = new MockHttpClient(
new MockResponse(
'content',
[
'response_headers' => ['x-my-custom' => ['my-value']],
]
)
);

$response = $this->makeProxy($client)->response('image.jpg');

self::assertSame('my-value', $response->headers->get('x-my-custom'));
}

public function testResponseNormalizesFileStrippingLeadingSlash(): void
Expand Down
Loading