Convert project to package from plugin package#21
Open
widarlein wants to merge 1 commit intobabstrap:mainfrom
Open
Convert project to package from plugin package#21widarlein wants to merge 1 commit intobabstrap:mainfrom
widarlein wants to merge 1 commit intobabstrap:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I converted this project to a package instead of a plugin since it doesn't use any platform specific code. I had problem with differences in Java version and I noticed this issue in the project #15 which spoke of the kotlin version. Since this is a flutter only package, there is no need for android or ios specific code, so I removed it thereby solving the whole issue.
You can read more about packages vs plugins here https://docs.flutter.dev/packages-and-plugins/using-packages
Work done
Tested and works well on android (no reason not to work well on any other platform) built on Flutter (Channel stable, 3.19.1, on macOS 14.4 23E214 darwin-arm64, locale en-SE)