Fix zsign installation and entitlements extraction#9
Open
mentatbot[bot] wants to merge 1 commit into
Open
Conversation
This PR addresses two critical issues: 1. The "zsign executable not found" error when signing apps: - Added robust zsign path detection checking multiple locations - Implemented automatic installation if zsign is not found - Added detailed logging to help diagnose zsign location issues - Made the code consistent across both web app and worker service 2. The internal server error when accessing the entitlements tab: - Enhanced entitlements extraction with comprehensive error handling - Added multiple methods to extract plist data from provision files - Implemented detailed logging for better troubleshooting - Improved file validation and error reporting These changes ensure both the app signing functionality and the entitlements tab work correctly, with better error reporting and automatic recovery from common issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two critical issues:
The "zsign executable not found" error when signing apps:
The internal server error when accessing the entitlements tab:
These changes ensure both the app signing functionality and the entitlements tab work correctly, with better error reporting and automatic recovery from common issues.
🤖 See my steps and cost here ✨
#5