fix(ui): move Save to the first tab stop in the comment popover footer#1122
Open
balasivagn wants to merge 1 commit into
Open
fix(ui): move Save to the first tab stop in the comment popover footer#1122balasivagn wants to merge 1 commit into
balasivagn wants to merge 1 commit into
Conversation
Reorders the comment popover footer so Save is the first focusable control after the textarea, ahead of Ask AI and the image-upload button. Tab order previously matched DOM order left-to-right (image icon, Ask AI, Save), so fast keyboard-driven flows (select text → comment → Tab, Tab, Enter) could land on the image-upload button instead of Save. Pure reorder, no behavior change. Fixes backnotprop#1121 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/ui/components/CommentPopover.tsx) so Save is the first focusable control after the textarea, ahead of Ask AI and the image-upload button.image icon → Ask AI → Save), so a fast keyboard flow (select text → comment → Tab, Tab, Enter) could land on the image-upload button instead of Save — the opposite of what you'd want for the primary action.Mod+Enter/Escapeare unaffected (they're wired on the textarea'sonKeyDown, independent of button DOM position). Applied identically to both duplicated footer blocks in the file (dialog/expanded mode and popover mode). SinceCommentPopoveris shared, this fixes both the plan-review and code-review surfaces.Fixes #1121
Test plan
packages/uitypechecks clean (tsc --noEmitonpackages/ui/tsconfig.jsonandtsconfig.strict-consumer.json)bun test— full suite passes (3 pre-existing, unrelated failures inpackages/core/crypto.test.tshitting the live paste service over the network, not touched by this change)apps/review+apps/hookbundles and manually verified in the review-editor dev server: Save appears leftmost, and tabbing from the textarea reaches Save before Ask AI / the image icon, in both the inline popover and expanded dialog variants