fix: Always include the default app-config.yaml from the Backstage image in the container command#291
Conversation
289c155 to
8e067b3
Compare
app-config.yaml from the Backstage imageapp-config.yaml from the Backstage image
app-config.yaml from the Backstage imageapp-config.yaml from the Backstage image in the container command
Signed-off-by: Armel Soro <asoro@redhat.com>
Signed-off-by: Armel Soro <asoro@redhat.com>
8e067b3 to
21d5345
Compare
Signed-off-by: Armel Soro <asoro@redhat.com>
21d5345 to
f6c068d
Compare
|
/cc @ChrisJBurns Thoughts on this? This is confirmed to fix issues like #290 |
|
@vinzscam Wondering what your thoughts are on this? I always defer to yourself when it comes to some of the app-config changes 😄 |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
not stale. |
vinzscam
left a comment
There was a problem hiding this comment.
I don't think we can assume that app-config.yaml exists. Also this is a breaking change for those adopters that don't want to always include app-config.yaml.
I think the problem is that the techdocs config isn't marked as optional. Opened backstage/backstage#31866
That makes sense. Closing this as not needed then. Thanks for your feedback. |
Description of the change
As reported in #290, deploying the current Helm Chart might result in a Backstage pod not being able to start due to a config validation error. You can run this command from the main branch to reproduce the issue:
To fix this issue (and also prevent future similar issues), I thought it would make sense to include the default
app-config.yamlfile in the backstage-backend container command, just like it is currently done in the backstage Dockerfile.Existing or Associated Issue(s)
Fixes #290
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-runto preview the content.ct lintcommand.