Skip to content

Update react-router monorepo to ^6.30.2 #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backstage-goalie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update react-router monorepo to ^6.30.2 #8533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions workspaces/bitbucket-pull-requests/.changeset/renovate-16bd52a.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@backstage-community/plugin-bitbucket-pull-requests': patch
---

Updated dependency `react-router` to `^6.30.2`.
Updated dependency `react-router-dom` to `~6.30.0`.
2 changes: 1 addition & 1 deletion workspaces/bitbucket-pull-requests/plugins/bitbucket-pull-requests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"peerDependencies": {
"react": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-router": "6.30.2 ^6.30.2"
"react-router": "^6.30.2"

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new peerDependency range for react-router (^6.30.2) is inconsistent with this package’s direct dependency on react-router (^6.3.0), which can lead to peer dependency warnings and potentially multiple router versions in consumer installs. Align the dependency and peerDependency ranges (or drop one of them) so they don’t conflict.

Suggested change
"react-router": "^6.30.2"
"react-router": "^6.3.0"

Copilot uses AI. Check for mistakes.

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peerDependencies.react-router is now a valid range (^6.30.2), but it is much stricter than this package’s direct dependencies (react-router/react-router-dom are still ^6.3.0). If the plugin is compatible with older v6 versions, consider aligning the peer range with the dependency range; if it truly requires >=6.30.2, bump the dependencies versions (and likely add a matching react-router-dom peer) to avoid confusing/unsatisfiable installs for consumers.

Suggested change
"react-router": "^6.30.2"
"react-router": "^6.3.0"

Copilot uses AI. Check for mistakes.
},
Comment on lines 54 to 58

Copilot AI Apr 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The react-router peerDependency is now ^6.30.2, but this package still lists react-router in dependencies as ^6.3.0. This can lead to confusing installs (consumer may satisfy dependencies via an older pinned react-router, while still failing the peer constraint). Consider aligning the dependency range with the peer range (or loosening the peer range if older 6.x is intended to be supported).

Copilot uses AI. Check for mistakes.
"devDependencies": {
"@backstage/cli": "^0.33.1",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/bitbucket-pull-requests/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1728,7 +1728,7 @@ __metadata:
peerDependencies:
react: ^16.13.1 || ^17.0.0 || ^18.0.0
react-dom: ^16.13.1 || ^17.0.0 || ^18.0.0
react-router: 6.30.2 ^6.30.2
react-router: ^6.30.2
languageName: unknown
linkType: soft

Expand Down
6 changes: 6 additions & 0 deletions workspaces/bookmarks/.changeset/renovate-16bd52a.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@backstage-community/plugin-bookmarks': patch
---

Updated dependency `react-router` to `^6.30.2`.
Updated dependency `react-router-dom` to `~6.30.0`.
2 changes: 1 addition & 1 deletion workspaces/bookmarks/plugins/bookmarks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"playwright-core": "*",
"react": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-dom": "^16.13.1 || ^17.0.0 || ^18.0.0",
"react-router-dom": "~6.27.0"
"react-router-dom": "~6.30.0"
},
"peerDependencies": {
"react": "^16.13.1 || ^17.0.0 || ^18.0.0",
Expand Down
32 changes: 16 additions & 16 deletions workspaces/bookmarks/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,7 +762,7 @@ __metadata:
playwright-core: "npm:*"
react: "npm:^16.13.1 || ^17.0.0 || ^18.0.0"
react-dom: "npm:^16.13.1 || ^17.0.0 || ^18.0.0"
react-router-dom: "npm:~6.27.0"
react-router-dom: "npm:~6.30.0"
peerDependencies:
react: ^16.13.1 || ^17.0.0 || ^18.0.0
react-dom: ^16.13.1 || ^17.0.0 || ^18.0.0
Expand Down Expand Up @@ -5324,10 +5324,10 @@ __metadata:
languageName: node
linkType: hard

"@remix-run/router@npm:1.20.0":
version: 1.20.0
resolution: "@remix-run/router@npm:1.20.0"
checksum: 10/e1d2420db94a1855b97f1784898d0ae389cf3b77129b8f419e51d4833b77ca2c92ac09e2cb558015324d64580a138fd6faa31e52fcc3ba90e3cc382a1a324d4a
"@remix-run/router@npm:1.23.2":
version: 1.23.2
resolution: "@remix-run/router@npm:1.23.2"
checksum: 10/50eb497854881bbd2e1016d4eb83c935ecd618e1c3888b74718851317e3b04edbaae9fe1baa49ec08c5c52cfe7118f4664e37144813d9500f45f922d6602a782
languageName: node
linkType: hard

Expand Down Expand Up @@ -19120,27 +19120,27 @@ __metadata:
languageName: node
linkType: hard

"react-router-dom@npm:~6.27.0":
version: 6.27.0
resolution: "react-router-dom@npm:6.27.0"
"react-router-dom@npm:~6.30.0":
version: 6.30.3
resolution: "react-router-dom@npm:6.30.3"
dependencies:
"@remix-run/router": "npm:1.20.0"
react-router: "npm:6.27.0"
"@remix-run/router": "npm:1.23.2"
react-router: "npm:6.30.3"
peerDependencies:
react: ">=16.8"
react-dom: ">=16.8"
checksum: 10/cfbcbc1d387d3341a335e3a075e487cc09dcbb62f1b83bc827fc3eec937523d5647a2c4488c804dc61581e65561823d0166d17b5dbc8579998c25b5a0bcabad6
checksum: 10/db974d801070e9967a076b31edca902e127793e02dc79f364461b94e81846a588c241d72e069f5b586b4a90ffd99798f5cb97753ac9d22fe90afa6dc008ab520
languageName: node
linkType: hard

"react-router@npm:6.27.0":
version: 6.27.0
resolution: "react-router@npm:6.27.0"
"react-router@npm:6.30.3":
version: 6.30.3
resolution: "react-router@npm:6.30.3"
dependencies:
"@remix-run/router": "npm:1.20.0"
"@remix-run/router": "npm:1.23.2"
peerDependencies:
react: ">=16.8"
checksum: 10/352e3af2075cdccf9d114b7e06d94a1b46a2147ba9d6e8643787a92464f5fd9ead950252a98d551f99f21860288bcf3a4f088cb5f46b28d1274a4e2ba24cc0f9
checksum: 10/1a51bdcc42b8d7979228dea8b5c44a28a4add9b681781f75b74f5f920d20058a92ffe5f1d0ba0621f03abe1384b36025b53b402515ecb35f27a6a2f2f25d6fbe
languageName: node
linkType: hard

Expand Down
Loading