fix(edit_uri): realpath page source path in root check#150
Open
El-cmd wants to merge 1 commit intobackstage:masterfrom
Open
fix(edit_uri): realpath page source path in root check#150El-cmd wants to merge 1 commit intobackstage:masterfrom
El-cmd wants to merge 1 commit intobackstage:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, paths like
/tmpand/varmay resolve to/private/tmpand/private/varthrough symlinks.EditUrl.__is_root()compared:realpath(abs_root_config_docs_dir)(canonicalized)self.page.file.abs_src_path(non-canonicalized)This could produce false mismatches when one side includes
/privateand the other does not.This PR canonicalizes both sides with
path.realpath()before comparison.Also added a minimal unit test to reproduce the macOS-style mismatch (
/var/...vs/private/var/...) and validate the fix.