Fix build errors and add error logging workflow#6
Closed
codegen-sh[bot] wants to merge 4 commits into
Closed
Conversation
|
If you would like me to review this PR, either tag me in a comment or check this box:
You can disable automatic comments on my settings page |
Author
|
Hey! 👋 I see one of the checks failed. I am on it! 🫡 |
Author
|
Hey! 👋 I see one of the checks failed. I am on it! 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the build errors in the executor repository and adds a workflow to save error logs as artifacts.
Changes:
Fixed Build Errors:
BytecodeConstants.hwith required constants for bytecode loading/*parameter*/comments<cstdlib>include for malloc/free functionsMacros.hfor common macros and definitionsImproved Makefile:
LUAU_PLATFORM_GENERICAdded Error Logging Workflow:
These changes make the codebase more portable and easier to build on different platforms while providing better error visibility through the GitHub Actions workflows.
💻 View my work • About Codegen