Skip to content

Fix build errors and add error logging workflow#6

Closed
codegen-sh[bot] wants to merge 4 commits into
mainfrom
codegen-bot/7ac5b6a5
Closed

Fix build errors and add error logging workflow#6
codegen-sh[bot] wants to merge 4 commits into
mainfrom
codegen-bot/7ac5b6a5

Conversation

@codegen-sh
Copy link
Copy Markdown

@codegen-sh codegen-sh Bot commented Apr 30, 2025

This PR addresses the build errors in the executor repository and adds a workflow to save error logs as artifacts.

Changes:

  1. Fixed Build Errors:

    • Added missing BytecodeConstants.h with required constants for bytecode loading
    • Fixed unused parameter warnings by adding /*parameter*/ comments
    • Added <cstdlib> include for malloc/free functions
    • Created Macros.h for common macros and definitions
  2. Improved Makefile:

    • Removed iOS-specific compiler flags
    • Simplified platform flags to use LUAU_PLATFORM_GENERIC
    • Fixed linking options
    • Removed clang-specific options
  3. Added Error Logging Workflow:

    • Created a GitHub Actions workflow to extract and save error logs as artifacts
    • Added a build workflow that captures build output
    • Configured error extraction to separate errors and warnings

These changes make the codebase more portable and easier to build on different platforms while providing better error visibility through the GitHub Actions workflows.


💻 View my workAbout Codegen

@mentatbot
Copy link
Copy Markdown

mentatbot Bot commented Apr 30, 2025

If you would like me to review this PR, either tag me in a comment or check this box:

  • Review PR

You can disable automatic comments on my settings page

@codegen-sh
Copy link
Copy Markdown
Author

codegen-sh Bot commented Apr 30, 2025

Hey! 👋 I see one of the checks failed. I am on it! 🫡

💻 View my work

@codegen-sh
Copy link
Copy Markdown
Author

codegen-sh Bot commented Apr 30, 2025

Hey! 👋 I see one of the checks failed. I am on it! 🫡

💻 View my work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant