Add submissions compatibility migration to add missing columns (including name)#192
Open
badjoke-lab wants to merge 1 commit into
Open
Add submissions compatibility migration to add missing columns (including name)#192badjoke-lab wants to merge 1 commit into
badjoke-lab wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/api/submissionswas failing with Postgres error 42703 for missing columnnamebecause the APIINSERTlist ininsertSubmissionToDbexpects columns that are absent in some DB deployments.Description
migrations/compat_submissions_columns.sqlwhich runs anALTER TABLE IF EXISTS public.submissionsandADD COLUMN IF NOT EXISTSfor all columns referenced by the APIINSERT(includingname,country,accepted_chains,submitted_by,payload,lat,lng, etc.).TEXT,TEXT[],JSONB,DOUBLE PRECISION,BOOLEAN,TIMESTAMPTZ) and left columns nullable where appropriate.docs/db.mdso operators can runpsql "$DATABASE_URL" -f migrations/compat_submissions_columns.sqlto apply the migration.Testing
Codex Task