Rewrite /map marker rendering to unified client-side supercluster index#376
Open
badjoke-lab wants to merge 1 commit into
Open
Rewrite /map marker rendering to unified client-side supercluster index#376badjoke-lab wants to merge 1 commit into
badjoke-lab wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
{ id, lat, lng, verification }and fullPlaceobjects are not used for marker layout.Description
components/map/MapClient.tsxto maintain onesuperclusterindex (clusterIndexRef) that is rebuilt on initial load and on filter changes and used for allmove/zoomreclustering viagetClusters(bounds, zoom).renderClustersto reuse existing Leaflet markers keyed bycluster:<id>/point:<id>and only remove stale items instead of wholesale layer replacement, reducing render churn and enabling smoother transitions.GET /api/places/pinsimplemented inapp/api/places/pins/route.tswhich returns minimal pin DTOs and reuseslistPlacesForMapunder the hood.60ms) so pins are fetched only on filters (and initial load), while pan/zoom uses local reclustering; kept places summary/detail fetches and list behaviour separate and intact.components/map/MapClient.tsx(marker/index/renderer rewrite, debounce, reuse logic) andapp/api/places/pins/route.ts(new marker-only route).Testing
npm run lint, which completed successfully with only linter warnings reported.npm run test:stats, which failed in the CI-like test environment due to a test runtime module resolution error (Cannot find module '@/lib/db') unrelated to the map changes and preventing full test execution.Codex Task