Small improvements#2
Open
newme616 wants to merge 3 commits intobadlogic:mainfrom
Open
Conversation
…ments - Remove redundant .padEnd() after truncateToWidth(..., true) which already pads to the target visual width - Move waitingUI above try block so the catch path can properly dismiss and await the TUI overlay before showing the error notification - Guard empty feedback: skip editor insertion when there are no comments or overall notes, show 'No feedback to insert' instead - Change review prompt from 'Please address the following feedback' to 'Address the following code review feedback:' — primes the model better by signaling this is code review context, and saves tokens by dropping the unnecessary 'please'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
already pads to the target visual width
and await the TUI overlay before showing the error notification
or overall notes
PS: AI slop with manual review ;)