Skip to content

Fix command injection vulnerability in git checkout function #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
semgrep-code-badoo wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix command injection vulnerability in git checkout function #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/util/git.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const spawn = require('child_process').spawn;
const exec = require('child_process').exec;
const execFile = require('child_process').execFile;

function clone(cwd, done) {
const proc = spawn('git', ['clone', '--progress', process.env.REPO, 'repo'], {
Expand All @@ -9,9 +9,20 @@ function clone(cwd, done) {
}

function checkout(cwd, hash, done) {
const cmd = `git checkout ${process.env.REPO_BRANCH} && git pull origin ${process.env.REPO_BRANCH} && git checkout ${hash}`;
exec(cmd, { cwd }, (err, stdout) => {
done(err, stdout);
const branch = process.env.REPO_BRANCH;

execFile('git', ['checkout', branch], { cwd }, (err1) => {
if (err1) {
return done(err1, null);
}
execFile('git', ['pull', 'origin', branch], { cwd }, (err2) => {
if (err2) {
return done(err2, null);
}
execFile('git', ['checkout', hash], { cwd }, (err3, stdout) => {
done(err3, stdout);
});
});
});
}

Expand Down