Skip to content

Implementation of edge insets for StepperView for positioning #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
badrinathvm wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implementation of edge insets for StepperView for positioning #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbbb28a
Implementation of edge insets for StepperView for positioning
May 20, 2021
76c6c95
Updated read me with edgeInsets modifier
May 20, 2021
349d408
Merge branch 'master' of https://github.com/badrinathvm/StepperView i…
May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Example/StepperView/ExampleView11.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ struct ExampleView11: View {
.lineOptions(StepperLineOptions.rounded(4, 8, Color(customGreen)))
.stepLifeCycles([StepLifeCycle.completed, .completed, .completed, .pending])
.spacing(40)
.edgeInsets(EdgeInsets(top: 2, leading: 5, bottom: 2, trailing: 5))
.padding(.leading, 50)

StepperView()
Expand Down
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,9 @@ dependencies: [

.pitStopLineOptions(_ options: [StepperLineOptions])
1. line customization `color` , `width` , `corner radius`

. edgeInsets(_ edgeInsets: EdgeInsets)
1. Places the stepper view for the insets provided.
```

## Usage
Expand Down
15 changes: 15 additions & 0 deletions Sources/StepperView/Extension/EnvironmentValues+Extension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,13 @@ extension EnvironmentValues {
get { self[StepLifeCycleKey.self] }
set { self[StepLifeCycleKey.self] = newValue }
}

/// property wrapper for `StepperEdgeInsetsKey`
var stepperEdgeInsets: EdgeInsets {
get { self[StepperEdgeInsetsKey.self] }
set { self[StepperEdgeInsetsKey.self] = newValue }
}

}

/// Environment Key for Steps
Expand Down Expand Up @@ -167,3 +174,11 @@ struct StepLifeCycleKey: EnvironmentKey {
/// provide a default value for custom dependency
static var defaultValue:[StepLifeCycle] = []
}

/// Environment Key for StepperEdgeInsets .
@available(iOS 13.0, OSX 10.15, tvOS 13.0, watchOS 6.0, *)
struct StepperEdgeInsetsKey: EnvironmentKey {
/// provide default values for Stepper Edge Insets
static var defaultValue: EdgeInsets =
EdgeInsets(top: Utils.standardSpacing, leading: Utils.standardSpacing, bottom: Utils.standardSpacing, trailing: Utils.standardSpacing)
Copy link
Contributor

@rcole34 rcole34 May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may slightly change the default spacing, as if you just add .padding() it uses the system default (varies based on device type and other conditions). If we made stepperEdgeInsets be optional EdgeInsets? with a default value of nil then passing .padding(nil) will retain the current behavior.

Copy link
Owner Author

@badrinathvm badrinathvm May 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am evaluating this default padding behaviour across all the watchOS, iOS and test it out.

}
5 changes: 5 additions & 0 deletions Sources/StepperView/Extension/View+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,4 +200,9 @@ public extension View {
print("** \(log)")
return EmptyView()
}

/// Sets edgeInsets for StepperView
func edgeInsets(_ edgeInsets: EdgeInsets) -> some View {
self.environment(\EnvironmentValues.stepperEdgeInsets, edgeInsets)
}
}
1 change: 0 additions & 1 deletion Sources/StepperView/Views/StepIndicatorHorizontalView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ struct StepIndicatorHorizontalView<Cell:View>: View {
.multilineTextAlignment(.center)
}


// MARK: - Performas line customization
/// draws custom line between the indicators
/// - Parameters:
Expand Down
5 changes: 4 additions & 1 deletion Sources/StepperView/Views/StepIndicatorVerticalView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ struct StepIndicatorVerticalView<Cell>: View where Cell:View {
/// environment variable to access steplife cycles
@Environment(\.stepLifeCycle) var stepLifeCycle

/// environment variable to access edgeInsets
@Environment(\.stepperEdgeInsets) var edgeInsets

/// list of `View's` to display step indictor content
var cells:[Cell]
/// list of alignments to display the step indicator position can be `top` or `center` or `bottom`
Expand Down Expand Up @@ -128,7 +131,7 @@ struct StepIndicatorVerticalView<Cell>: View where Cell:View {
self.dynamicSpace = Array($0.values).max() ?? 0.0
//print("Auto Spacing:: \(self.dynamicSpace)")
}
}.padding()
}.padding(edgeInsets)
}
}

Expand Down