Criar flag --tag para comando create cluster#172
Open
CarlosSMA wants to merge 7 commits intobadtuxx:mainfrom
Open
Criar flag --tag para comando create cluster#172CarlosSMA wants to merge 7 commits intobadtuxx:mainfrom
--tag para comando create cluster#172CarlosSMA wants to merge 7 commits intobadtuxx:mainfrom
Conversation
…tend" e "girus-backend"
Collaborator
|
@CarlosSMA muito bom seu PR! |
0a68523 to
813a0be
Compare
Author
|
@ricardosilva86 Obrigado pelo feedback! Fiz push do commit 813a0be, que contém a tua sugestão de termos flags diferentes. Se o Jef optar por manter como uma flag só, podemos fazer um revert desse commit somente. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround que implementei ao encontrar a Issue #171.
Permite que o usuário defina a
tagdas imagenslinuxtips/girus-frontendelinuxtips/girus-backende mantémlatestcomo padrão. Acho interessante ser implementado porque evita a modificação dos manifestos YAML dos deployments, e permite o uso dogiruscaso haja algum problema nas imagens mais recentes.Teste
Dúvidas
~/.girus/config.yaml?