Add error detection for file loading failures in test framework#6
Open
jjtolton wants to merge 2 commits intobakaq:mainfrom
Open
Add error detection for file loading failures in test framework#6jjtolton wants to merge 2 commits intobakaq:mainfrom
jjtolton wants to merge 2 commits intobakaq:mainfrom
Conversation
When test files fail to load due to syntax errors, the testing framework now detects that no tests were found and reports a clear error message in red text. This makes it obvious that something went wrong with file loading, rather than silently skipping to successful execution. - Detect when no tests are found in any module - Report error in red text: "ERROR: No tests found. This may indicate a file loading error." - Return exit code 1 on file loading errors (matching test failure behavior) - Add test files demonstrating syntax error detection 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Demonstrates all test scenarios in one convenient script - Shows syntax error detection with red error message - Shows passing tests scenario - Shows mixed pass/fail scenario - Shows alternate syntax error type - Validates exit codes are correct for each scenario - All tests passing with ✓ indicators Usage: ./example/run_error_detection_tests.sh 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds error detection to catch when test files fail to load due to syntax errors. The framework now detects empty test lists and reports a clear error message instead of silently passing.
Fixes #5
Test Plan
All scenarios pass with correct exit codes:
Run
./example/run_error_detection_tests.shto see all test scenarios.Implementation Details
run_tests_opt/4to check test discovery resultscollect_all_tests/2helper predicate