feat: Double Ctrl+C to close pgxcli#95
Draft
LeeFred3042U wants to merge 1 commit into
Draft
Conversation
Owner
|
Hi, since both share the same state, pressing Esc and Ctrl+C will close the pgxcli. How about using a global sequence counter and splitting the states? |
Contributor
Author
|
@balajz ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
Changes
internal/app/ui/model.goctrlcSeq intfield toModelto track the current Ctrl+C seq generatedUpdate():StatePendingguard to also excludeInterruptkeyseqTimeoutMsgcase to also checkctrlcSeqInterrupthandler insidetea.KeyMsgblock:StateInputsetsStatePendingand fires atea.TickQuitRequestMsgand returns toStateInputStateExecutingremains instant cancel, no double press requiredNotes
keys.go:Interruptis already connected toctrl+cStatePendingandseqTimeoutMsgintroduced in feat: double ESC to clear the input #73