[BALDE-10] Implement big file reader for Windows.#67
Open
[BALDE-10] Implement big file reader for Windows.#67
Conversation
BIGbadEL
added
the
merge asap
Blinkuu
requested changes
Jul 25, 2019
| ${CMAKE_CURRENT_SOURCE_DIR}/src/core/platform/opengl/buffers/opengl_vertex_array.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/src/core/platform/opengl/shaders/opengl_shader.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/src/core/utils/file_manager.cpp | ||
| src/core/utils/file_manager/file_manager.cpp |
Collaborator
There was a problem hiding this comment.
add ${CMAKE_CURRENT_SOURCE_DIR}/
| CORE_LOG_INFO("[FILE_MANAGER] Error: Windows implementation is not done yet! Using slower reading method!"); | ||
| ReadSmallFile(filePath); | ||
| // CORE_LOG_INFO("[FILE_MANAGER] Error: Windows implementation is not done yet! Using slower reading method!"); | ||
| // ReadSmallFile(filePath); |
| std::streampos begin,end; | ||
| std::ifstream file(filePath, std::ios::in); | ||
| char* buffer; | ||
| if(file.is_open()){ |
Collaborator
There was a problem hiding this comment.
Did you do some research on the performance of this code?
| @@ -19,7 +19,7 @@ namespace Bald::Utils { | |||
| * ENUM which determines size of file and therefor methods, which will be used to read it | |||
| */ | |||
| enum class Size : char { | |||
| SMALL_FILE, BIG_FILE | |||
Collaborator
There was a problem hiding this comment.
We need to have fixed convention for enum naming
piotrmoszkowicz
requested review from
piotrmoszkowicz
and removed request for
piotrmoszkowicz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.