This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Fill / persist all iovecs in FileDisk.request.#20
Open
zvin wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
There is one problem with this PR: none of the tests calls FileDisk.request with an iovecs array containing more than one buffer. |
Contributor
Author
|
The second commit implements writeBuffers using writev and pwritev syscalls. I was hoping that this would trigger a call to FileDisk.request with an iovecs array containing more than one buffer. But at least now we have a writeBuffers implementation. |
zvin
force-pushed
the
fill-all-iovecs
branch
2 times, most recently
from
c274ce5 to
36810a8
Compare
Change-Type: patch
Change-Type: patch
petrosagg
reviewed
Apr 1, 2021
Contributor
petrosagg
left a comment
petrosagg
left a comment
There was a problem hiding this comment.
No-op review to dismiss stale review request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Type: patch