Skip to content
This repository was archived by the owner on Jan 29, 2026. It is now read-only.

Guess the filesystem when none is given.#21

Open
zvin wants to merge 1 commit into
masterfrom
guess-filesystem
Open

Guess the filesystem when none is given.#21
zvin wants to merge 1 commit into
masterfrom
guess-filesystem

Conversation

@zvin
Copy link
Copy Markdown
Contributor

@zvin zvin commented Mar 14, 2017

Change-Type: patch

@zvin zvin requested a review from petrosagg March 14, 2017 11:34
@zvin zvin force-pushed the guess-filesystem branch 2 times, most recently from 25e2dad to e112460 Compare March 14, 2017 11:45
@zvin zvin force-pushed the guess-filesystem branch 2 times, most recently from a4ea4a2 to 79794c9 Compare March 23, 2017 12:40
@zvin zvin force-pushed the guess-filesystem branch 2 times, most recently from ea9da6a to 9192f8a Compare April 6, 2017 14:26
@ghost
Copy link
Copy Markdown

ghost commented Apr 6, 2017

VersionBot failed to carry out a status check for the above pull request here: #21. The reason for this is:
Github API timed out, could not complete
Please carry out relevant changes or alert an appropriate admin.

Copy link
Copy Markdown
Contributor

@petrosagg petrosagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm not fully on board with the direction of this PR. A better solution IMO is to provide a function that detects the filesystem and let the user do it.

@zvin zvin force-pushed the guess-filesystem branch from 9192f8a to e5fb3fb Compare May 17, 2017 10:24
@zvin zvin force-pushed the guess-filesystem branch from e5fb3fb to e293e16 Compare May 17, 2017 10:24
@zvin
Copy link
Copy Markdown
Contributor Author

zvin commented May 17, 2017

@petrosagg apparently this is what mount does when no filesystem is provided.
What do you think I should use to detect the filesystem instead?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants