Skip to content

add resampling option and thus fix the test instability#59

Merged
balparda merged 7 commits into
mainfrom
fix-test
Jun 19, 2026
Merged

add resampling option and thus fix the test instability#59
balparda merged 7 commits into
mainfrom
fix-test

Conversation

@balparda

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 19, 2026 13:08
@balparda balparda requested a review from BellaKeri as a code owner June 19, 2026 13:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to experiment with changing the default pixel resampling behavior (affecting golden hashes), while temporarily disabling large portions of the integration test suite.

Changes:

  • Switched DEFAULT_RESAMPLING from BICUBIC to the custom BILINEAR implementation.
  • Updated several golden output hash constants used by CLI/integration tests.
  • Disabled multiple integration tests (and reduced Python/Cython equivalence coverage) via unconditional @pytest.mark.skip and by removing the python parametrized case.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.

File Description
tests_integration/test_installed_cli.py Adds unconditional skips to installed-wheel CLI integration tests, significantly reducing coverage.
tests_integration/test_cython_equivalence.py Removes the python parametrized run for an “equivalence” test, adds debug printing, and skips several integration tests.
src/tranzoom/core/pixels.py Changes the default resampling mode to BILINEAR, impacting rendered output determinism and docs expectations.
src/tranzoom/cli/base.py Updates golden hashes to match new rendered output behavior.

Comment thread tests_integration/test_installed_cli.py Outdated
Comment thread tests_integration/test_installed_cli.py Outdated
Comment thread tests_integration/test_installed_cli.py Outdated
Comment thread tests_integration/test_cython_equivalence.py
Comment thread tests_integration/test_cython_equivalence.py
Comment thread tests_integration/test_cython_equivalence.py Outdated
Comment thread tests_integration/test_cython_equivalence.py Outdated
Comment thread tests_integration/test_cython_equivalence.py Outdated
Comment thread tests_integration/test_cython_equivalence.py Outdated
Comment thread src/tranzoom/core/pixels.py Outdated
@balparda balparda changed the title test hypothesis add resampling option and thus fix the test instability Jun 19, 2026
@balparda balparda requested a review from Copilot June 19, 2026 17:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 23 changed files in this pull request and generated 13 comments.

Comment thread src/tranzoom/cli/base.py
Comment thread CHANGELOG.md
Comment thread src/tranzoom/core/image.py
Comment thread README.md Outdated
Comment thread tests_integration/test_cython_equivalence.py
Comment thread tests_integration/test_cython_equivalence.py
Comment thread tranz.md Outdated
Comment thread tranz.md Outdated
Comment thread .github/workflows/ci.yaml Outdated
Comment thread tests_integration/test_cython_equivalence.py Outdated

@BellaKeri BellaKeri left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job

@balparda balparda merged commit 5bd810b into main Jun 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants