Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to experiment with changing the default pixel resampling behavior (affecting golden hashes), while temporarily disabling large portions of the integration test suite.
Changes:
- Switched
DEFAULT_RESAMPLINGfromBICUBICto the customBILINEARimplementation. - Updated several golden output hash constants used by CLI/integration tests.
- Disabled multiple integration tests (and reduced Python/Cython equivalence coverage) via unconditional
@pytest.mark.skipand by removing thepythonparametrized case.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
tests_integration/test_installed_cli.py |
Adds unconditional skips to installed-wheel CLI integration tests, significantly reducing coverage. |
tests_integration/test_cython_equivalence.py |
Removes the python parametrized run for an “equivalence” test, adds debug printing, and skips several integration tests. |
src/tranzoom/core/pixels.py |
Changes the default resampling mode to BILINEAR, impacting rendered output determinism and docs expectations. |
src/tranzoom/cli/base.py |
Updates golden hashes to match new rendered output behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.