Skip to content

turn: check fd deref cleanup on turn worker thread#8

Open
jobo-zt wants to merge 11 commits intobaresip:turn_threadfrom
jobo-zt:turn_thread
Open

turn: check fd deref cleanup on turn worker thread#8
jobo-zt wants to merge 11 commits intobaresip:turn_threadfrom
jobo-zt:turn_thread

Conversation

@jobo-zt
Copy link
Copy Markdown

@jobo-zt jobo-zt commented Oct 18, 2024

No description provided.

Comment thread modules/turn/turn.c Outdated
Comment thread modules/turn/turn.c
@jobo-zt
Copy link
Copy Markdown
Author

jobo-zt commented Oct 19, 2024

Discovered during testing。

thread 1
thrd_t *thrd= thrd_current();

thread 2
thrd_equal(thrd, thrd_current());

GetThreadId(thrd_current()) return ok. but GetThreadId(thrd) return err. thrd in thread 1
so fun thrd_equal return err.

I wrote a test program, but the problem doesn't always occur.

@jobo-zt
Copy link
Copy Markdown
Author

jobo-zt commented Oct 19, 2024

  1. we may need to use the function get_thread_id() in trace.c instead.
  2. we need to confirm whether thrd_equal will affect the re module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants