test: extend the remaining bulk-operation trash waits to 60s#26
Merged
Conversation
PR #25 gave the purge waits a 60s budget, but the same load-induced flake (GitHub #24) lives in every wait that gates on a multi-file storage round trip: PR #22's CI just failed on the bigbatch grouping wait — 25 children plus the folder marker copied into Trash, against the 15s default, on a runner where the suite's first test alone took 13s. The 12-file bulk-selection waits are one slow runner away from the same failure, so all three get the 60s budget now. Follow-up to #24. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesTrash scenario waits
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #25 gave the trash purge waits a 60s budget, but the same load-induced flake (#24) lives in every wait that gates on a multi-file storage round trip. PR #22's CI just failed on the next one over: the bigbatch grouping wait (
queryAllByText("bigbatch").length === 1) — 25 children plus the folder marker have to be copied into Trash before that row can appear, and the 15s default ran out on a runner where the suite's very first test alone took 13s.This extends the three remaining bulk-operation waits in
foldersAndTrash.tsto the same 60s budget:Follow-up to #24 / #25. Once merged, re-running #22's failed
checkjob should go green (the job tests the PR merge ref, so it picks this up without a rebase).🤖 Generated with Claude Code
Summary by CodeRabbit