Skip to content

test: extend the remaining bulk-operation trash waits to 60s#26

Merged
baronunread merged 1 commit into
mainfrom
fix/issue-24-followup-bulk-waits
Jul 17, 2026
Merged

test: extend the remaining bulk-operation trash waits to 60s#26
baronunread merged 1 commit into
mainfrom
fix/issue-24-followup-bulk-waits

Conversation

@baronunread

@baronunread baronunread commented Jul 17, 2026

Copy link
Copy Markdown
Owner

PR #25 gave the trash purge waits a 60s budget, but the same load-induced flake (#24) lives in every wait that gates on a multi-file storage round trip. PR #22's CI just failed on the next one over: the bigbatch grouping wait (queryAllByText("bigbatch").length === 1) — 25 children plus the folder marker have to be copied into Trash before that row can appear, and the 15s default ran out on a runner where the suite's very first test alone took 13s.

This extends the three remaining bulk-operation waits in foldersAndTrash.ts to the same 60s budget:

  • the bigbatch grouping wait (the one that actually failed)
  • the 12-file bulk-selection removal check
  • the trash listing check for those same 12 items

Follow-up to #24 / #25. Once merged, re-running #22's failed check job should go green (the job tests the PR merge ref, so it picks this up without a rebase).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Improved reliability of Trash-related scenarios involving large folders and selections by allowing additional time for storage operations to complete.

PR #25 gave the purge waits a 60s budget, but the same load-induced
flake (GitHub #24) lives in every wait that gates on a multi-file
storage round trip: PR #22's CI just failed on the bigbatch grouping
wait — 25 children plus the folder marker copied into Trash, against
the 15s default, on a runner where the suite's first test alone took
13s. The 12-file bulk-selection waits are one slow runner away from
the same failure, so all three get the 60s budget now.

Follow-up to #24.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0a25942-6e37-4f35-adc2-42fea24b41de

📥 Commits

Reviewing files that changed from the base of the PR and between 82f121d and 8007bd6.

📒 Files selected for processing (1)
  • tests/scenarios/foldersAndTrash.ts

📝 Walkthrough

Walkthrough

Changes

Trash scenario waits

Layer / File(s) Summary
Extend Trash assertion waits
tests/scenarios/foldersAndTrash.ts
Folder grouping and large-selection Trash assertions now use explicit 60_000 millisecond waitFor timeouts.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: extending remaining trash-related bulk-operation waits to 60s.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-24-followup-bulk-waits

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@baronunread

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@baronunread
baronunread merged commit 4207b5c into main Jul 17, 2026
4 checks passed
@baronunread
baronunread deleted the fix/issue-24-followup-bulk-waits branch July 17, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant