Skip to content

test: stop rebuilding folderInfo() across clock ticks in listingCache tests #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baronunread merged 1 commit into from
Jul 17, 2026
Merged

test: stop rebuilding folderInfo() across clock ticks in listingCache tests #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions tests/unit/ui/listingCache.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,12 @@ describe("listingCache", () => {

const first = fetchFolderInfo("conn-b", "photos/", fetcher);
const second = fetchFolderInfo("conn-b", "photos/", fetcher);
release(folderInfo(5));
expect(await first).toEqual(folderInfo(5));
expect(await second).toEqual(folderInfo(5));
// One shared object: folderInfo() stamps lastModified with Date.now(),
// so building it twice flakes whenever the ms clock ticks in between.
const released = folderInfo(5);
release(released);
expect(await first).toEqual(released);
expect(await second).toEqual(released);
expect(calls).toBe(1);
});

Expand Down Expand Up @@ -184,7 +187,10 @@ describe("listingCache", () => {
putListing("conn-a", "photos/", [FILE_B]);
await fetchFolderInfo("conn-a", "photos/", async () => folderInfo(1));
putListing("conn-b", "", [FILE_B]);
await fetchFolderInfo("conn-b", "photos/", async () => folderInfo(9));
// Kept in a const for the same clock-tick reason as the inflight-dedupe
// test above — this exact flake hit CI on a loaded runner (PR #22).
const infoB = folderInfo(9);
await fetchFolderInfo("conn-b", "photos/", async () => infoB);

invalidateConnection("conn-a");

Expand All @@ -193,7 +199,7 @@ describe("listingCache", () => {
expect(peekFolderInfo("conn-a", "photos/")).toBeUndefined();

expect(peekListing("conn-b", "")).toEqual([FILE_B]);
expect(peekFolderInfo("conn-b", "photos/")).toEqual(folderInfo(9));
expect(peekFolderInfo("conn-b", "photos/")).toEqual(infoB);
});
});
});