Open
Conversation
pablosole
suggested changes
Jun 7, 2021
Contributor
Author
@pablosole done, check now pls |
ghost
approved these changes
Jun 11, 2021
pablosole
suggested changes
Jun 16, 2021
| type: integer | ||
| updated_at: | ||
| type: string | ||
| format: date-time |
There was a problem hiding this comment.
missing the "enrollment_url" that is only returned on creation.
| } | ||
| return resp.Payload.UserDirectory, nil | ||
| }, func(data interface{}) { // printSuccess func | ||
| userdirectory := data.(models.UserDirectory) |
There was a problem hiding this comment.
this response has the enrollment_url on it that is only returned on creation, I think you should print that separately from the table with a message or something saying "you put this on the connector", whatever we are doing in the proxy add flow (or if we are not doing it there we should also fix that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.