New small feature and a few bug fixes related to IPC#27
Open
lsnider wants to merge 18 commits into
Open
Conversation
|
Tried to fix some codeclimate issues and made it angrier. I'll leave this in the capable hands of @ablyler :) |
deprecated braces moved to brackets
* convert from declare ticks to pcntl_async_signals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature
child_send_result_to_parentBugs
fixed issue where caller could call
register_parent_prefork()without an array but the code relies on it being an arrayfixed an issue where a signal interrupting
socket_receiveorsocket_sendwould cause the protocol to get out of sync. without the signal block, sometimes the payload header was being partially consumed resulting in a mixup of the payload header and payloadfixed an issue where a signal interrupting
fetch_resultscould remove a pid from$this->forked_children, get added back in with just alast_activefield and later throw an undefinedindexerror. there was a fix in place to fix barracuda bug BNBS-23987. the fix helped with the race condition but did not solve it. in addition, the fix destroys child results that might have not been processed yet. the solution was to disable ticks during thefetch_resultsfunction and remove the earlier fix attempt.fixed an issue where the IPC sockets were not being stored for helper children
fixed an issue where helper children were not calling
srandcausing the helper children to get same random numbers as the parentfixed an issue where helper children were not honoring the
respawnparameter