Rewrite state management with pure tree operations#45
Merged
Conversation
Replace mutation-based tree operations with immutable pure functions using structural sharing. Remove lodash dependency. - 12-32x faster updates (no more cloneDeep on every change) - 11-13x faster selection - Reorganize src/ into components/, tree/, hooks/, types.ts
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lodashandpolishedfrom production dependenciessrc/intocomponents/,tree/,hooks/,types.tsPerformance
Compared against the previous
cloneDeep-based implementation:What changed
find,update,move,setSelected) are now pure functions that return new data instead of mutating the input arraytriggerOnChangeflag andselectedOnChange(dead code) removedonChangeis called directly from each handler instead of through a deferreduseEffectlodashremoved (no morecloneDeep)polishedremoved (replaced with CSScolor-mix())