You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of having the root ZFS mountpoint set to /iocell which might not be the most standard way to store files at, this PR sets the default mountpoint to /usr/local/iocell.
From the source-code, only lib/ioc-globals and lib/ioc-zsh require changes.
Other utility scripts use ${pool}/iocell which is always relative to the ZFS pool initialised with iocell activate $POOL.
To make such change accepted, you need to provide not only sufficient testing suite (ideally, for every single subcommand) but also a migration path for users with current version of iocell.
This PR should only affect new iocell installations (when running iocell activate $POOL).
It affects the ZFS mounting point when activating the service for the first time. After activation all iocell commands use ${pool}/iocell instead of the absolute path.
I'm not completely sure how lib/ioc-globals is affected when upgrading. Will it change iocroot=/iocell to iocroot=/usr/local/iocell (and break things) or leave it untouched because it detects that both versions diverge?
If I edit the content of /usr/local/lib/iocell/ioc-globals on my local system, when deleting or reinstalling the package, the file is left untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having the root ZFS mountpoint set to
/iocellwhich might not be the most standard way to store files at, this PR sets the default mountpoint to/usr/local/iocell.See issue #32 for more details.