Skip to content

Conversation

@wlawt
Copy link
Contributor

@wlawt wlawt commented Jan 15, 2026

Changes

  • Introduces a new metric fb_inclusion_duration
  • Records the metric when it sees the txhash in a PendingBlock. NOTE: on FB inclusion, it does not remove the TxHash in the Tracker's cache. This is to let us record when its included in the canonical block for the other existing metrics.
  • Moved build_eip1559_tx into shared test_utils

TODO

  • Add a unit test that invokes track_flashblock_transactions

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 15, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wlawt wlawt changed the title feat(txpool/tracker): make tracker fb aware WIP - feat(txpool/tracker): make tracker fb aware Jan 15, 2026
}

/// Track the first time we see a transaction in the mempool.
pub fn transaction_inserted(&mut self, tx_hash: TxHash, event: TxEvent) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, a transaction sent to us is sent to both the builder and the mpool, at the same time. Therefore, this should be accurate, as we'll start tracking right when we see it in the mpool to when it's in a PendingBlock

@wlawt wlawt changed the title WIP - feat(txpool/tracker): make tracker fb aware feat(txpool/tracker): make tracker fb aware Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants