-
Notifications
You must be signed in to change notification settings - Fork 111
feat(txpool/tracker): make tracker fb aware #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wlawt
wants to merge
9
commits into
main
Choose a base branch
from
tracker-fb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
|
wlawt
commented
Jan 15, 2026
| } | ||
|
|
||
| /// Track the first time we see a transaction in the mempool. | ||
| pub fn transaction_inserted(&mut self, tx_hash: TxHash, event: TxEvent) { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, a transaction sent to us is sent to both the builder and the mpool, at the same time. Therefore, this should be accurate, as we'll start tracking right when we see it in the mpool to when it's in a PendingBlock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fb_inclusion_durationPendingBlock. NOTE: on FB inclusion, it does not remove the TxHash in the Tracker's cache. This is to let us record when its included in the canonical block for the other existing metrics.build_eip1559_txinto shared test_utilsTODO
track_flashblock_transactions