Skip to content

fix: remove hardcoded Engine API JWT secret and require explicit configuration #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erhnysr wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −4
Open

fix: remove hardcoded Engine API JWT secret and require explicit configuration #1087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .env.mainnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ BASE_NODE_L1_TRUST_RPC="false"
# --------------------
BASE_NODE_L2_ENGINE_RPC=ws://execution:8551
BASE_NODE_L2_ENGINE_AUTH=/tmp/engine-auth-jwt
BASE_NODE_L2_ENGINE_AUTH_RAW=688f5d737bad920bdfb2fc2f488d6b6209eebda1dae949a8de91398d932c517a
# [REQUIRED] Generate with: openssl rand -hex 32
BASE_NODE_L2_ENGINE_AUTH_RAW=<your-secret-jwt>

# P2P CONFIGURATION
# -----------------
Expand Down
3 changes: 2 additions & 1 deletion .env.sepolia
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ BASE_NODE_L1_TRUST_RPC="false"
# --------------------
BASE_NODE_L2_ENGINE_RPC=http://execution:8551
BASE_NODE_L2_ENGINE_AUTH=/tmp/engine-auth-jwt
BASE_NODE_L2_ENGINE_AUTH_RAW=688f5d737bad920bdfb2fc2f488d6b6209eebda1dae949a8de91398d932c517a
# [REQUIRED] Generate with: openssl rand -hex 32
BASE_NODE_L2_ENGINE_AUTH_RAW=<your-secret-jwt>

# P2P CONFIGURATION
# -----------------
Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ The following are the hardware specifications we use in production:
- `BASE_NODE_L1_BEACON`: your L1 beacon node endpoint
- `BASE_NODE_NETWORK`: `base` or `base-sepolia`
- `RETH_CHAIN`: `base` or `base-sepolia`
- `BASE_NODE_L2_ENGINE_AUTH_RAW`: a 32-byte hex secret shared between the execution and consensus containers — **never use the placeholder value**. Generate with:
```bash
openssl rand -hex 32
```

### Network Settings

Expand Down
6 changes: 4 additions & 2 deletions consensus-entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ if [[ -z "${BASE_NODE_L2_ENGINE_AUTH:-}" ]]; then
exit 1
fi

if [[ -z "${BASE_NODE_L2_ENGINE_AUTH_RAW:-}" ]]; then
echo "expected BASE_NODE_L2_ENGINE_AUTH_RAW to be set" 1>&2
if [[ -z "${BASE_NODE_L2_ENGINE_AUTH_RAW:-}" || "${BASE_NODE_L2_ENGINE_AUTH_RAW}" == "<your-secret-jwt>" ]]; then
echo "ERROR: BASE_NODE_L2_ENGINE_AUTH_RAW is not set or still uses the placeholder value." >&2
echo "Generate a secret and set it in your .env file:" >&2
echo " BASE_NODE_L2_ENGINE_AUTH_RAW=\$(openssl rand -hex 32)" >&2
exit 1
fi

Expand Down
7 changes: 7 additions & 0 deletions execution-entrypoint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,13 @@ fi

mkdir -p "$RETH_DATA_DIR"
echo "Starting reth with additional args: $ADDITIONAL_ARGS"

if [[ -z "${BASE_NODE_L2_ENGINE_AUTH_RAW:-}" || "${BASE_NODE_L2_ENGINE_AUTH_RAW}" == "<your-secret-jwt>" ]]; then
echo "ERROR: BASE_NODE_L2_ENGINE_AUTH_RAW is not set or still uses the placeholder value." >&2
echo "Generate a secret and set it in your .env file:" >&2
echo " BASE_NODE_L2_ENGINE_AUTH_RAW=\$(openssl rand -hex 32)" >&2
exit 1
fi
echo "$BASE_NODE_L2_ENGINE_AUTH_RAW" > "$BASE_NODE_L2_ENGINE_AUTH"

exec "$BINARY" node \
Expand Down