Skip to content

Avoid unauthenticated Engine API probe in consensus-entrypoint#1099

Open
riyue121 wants to merge 2 commits into
base:mainfrom
riyue121:fix-consensus-entrypoint-el-ready-check
Open

Avoid unauthenticated Engine API probe in consensus-entrypoint#1099
riyue121 wants to merge 2 commits into
base:mainfrom
riyue121:fix-consensus-entrypoint-el-ready-check

Conversation

@riyue121
Copy link
Copy Markdown

Summary

This PR updates the consensus-entrypoint readiness check to avoid probing the execution client's Engine/Auth RPC endpoint without JWT authentication.

Previously, the script used:

curl "${BASE_NODE_L2_ENGINE_RPC/ws/http}"

When BASE_NODE_L2_ENGINE_RPC=ws://execution:8551, this expands to:

http://execution:8551

This sends an unauthenticated request to the Engine/Auth RPC endpoint. base-reth-node correctly returns 401, but it also logs the request as an error:

Invalid JWT: Authorization header is missing or invalid

This is a false positive and can be confusing during node operations and debugging.

Change

Instead of probing the Engine/Auth RPC endpoint, this PR checks the regular execution JSON-RPC endpoint using eth_chainId:

curl -s --max-time 10 --connect-timeout 5 \
  -H 'Content-Type: application/json' \
  -d '{"jsonrpc":"2.0","method":"eth_chainId","params":[],"id":1}' \
  http://execution:8545 | grep -q '"result":"0x2105"'
Motivation

This avoids generating misleading Invalid JWT errors in the execution logs while still ensuring that the execution client RPC is ready before starting base-consensus.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 22, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants